refactor(network): retrieves api versions and urls based on network store #362
Conversation
ygrishajev
force-pushed
the
feature/network
branch
from
e478d99
to
69b3d96
Compare
ygrishajev
force-pushed
the
feature/network
branch
from
69b3d96
to
1115948
Compare
| BASE_API_MAINNET_URL= | ||
| BASE_API_TESTNET_URL= | ||
| BASE_API_SANDBOX_URL= |
There was a problem hiding this comment.
in docker compose env server and browser hosts are different
| */ | ||
| export const initiateNetworkData = async () => { | ||
| networks = await Promise.all( | ||
| export const initiateNetworkVersions = async () => { |
There was a problem hiding this comment.
ideally this shouldn't happen. We could have a dedicated components/components blocking app rendering during init. I understand that it happens in SettingsProvider, however it's opaque and one should really dig in to understand this.
There was a problem hiding this comment.
Yea we could, but the version isn't really mandatory for the app the to render. I think we only show it in the NetworkSelect component.
There was a problem hiding this comment.
Well it's used in many api urls
| @@ -11,4 +13,6 @@ export type Network = { | |||
| rpcEndpoint?: string; | |||
| version: string | null; | |||
| enabled: boolean; | |||
| apiVersion: ApiVersion; | |||
| marketApiVersion: ApiVersion; | |||
There was a problem hiding this comment.
moved these here as it's really a network config, and we have selected network definition logic based on configs already.
| static sandboxVersion() { | ||
| return `${browserEnvConfig.NEXT_PUBLIC_API_BASE_URL}/v1/version/sandbox`; | ||
|
|
||
| static get baseApiUrl() { |
There was a problem hiding this comment.
fixes a bug introduced by me earlier - api url should vary based on the network for the above endpoints
ygrishajev
changed the title
| */ | ||
| export const initiateNetworkData = async () => { | ||
| networks = await Promise.all( | ||
| export const initiateNetworkVersions = async () => { |
There was a problem hiding this comment.
Yea we could, but the version isn't really mandatory for the app the to render. I think we only show it in the NetworkSelect component.
Network service was bothering me a bit and I went for refactoring. The root of it is attempt to depend on a single source of truth which is a network store that already holds a selected network with all its configurations.