Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(billing): rename POST /v1/wallets to POST /v1/start-trial #388

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

ygrishajev
Copy link
Collaborator

@ygrishajev ygrishajev commented Sep 26, 2024

The main purpose for the change - target the endpoint for rate limiting with Cloudflare. However this actually makes sense from app standpoint as this endpoint does more than just wallet creation - it also grants trial allowances. So this is a business workflow that should better be called respectively.

@ygrishajev ygrishajev merged commit b39b057 into main Sep 26, 2024
5 checks passed
@ygrishajev ygrishajev deleted the feature/billing branch September 26, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants