Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gRPC Endpoints #232

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

gRPC Endpoints #232

wants to merge 22 commits into from

Conversation

andrewhare
Copy link
Contributor

@andrewhare andrewhare commented Apr 16, 2024

Resolves akash-network/support#221
Relies on akash-network/akash-api#164

Convert REST handlers to gRPC.

LeaseService

ProviderService

  • GetStatus: Done
  • StreamStatus: Done
  • GetVersion: Done
  • Validate: Done
  • WIBOY: Done

NOTE

This PR has akash-api manually pinned to the PR commit. Once akash-network/akash-api#164 is merged, that will be need to be undone.

@andrewhare andrewhare changed the title gRCP Setup StreamServiceLogs Apr 24, 2024
@andrewhare
Copy link
Contributor Author

@troian This PR is now just for StreamServiceLogs. This is ready for review now.

@andrewhare
Copy link
Contributor Author

@troian Can you take a look at https://github.com/akash-network/provider/pull/232/files#diff-ad05e1c650e40b9d96f8e6be2ce651a482926400144ddfe3c90363c23a449379R35-R36. I'm assuming we ignore this value for streaming the logs?

@andrewhare
Copy link
Contributor Author

@troian Can you take a look at https://github.com/akash-network/provider/pull/232/files#diff-ad05e1c650e40b9d96f8e6be2ce651a482926400144ddfe3c90363c23a449379R35-R36. I'm assuming we ignore this value for streaming the logs?

Never mind, I found where it's used, and it's ignored if follow is true.

@andrewhare andrewhare changed the title StreamServiceLogs gRPC Endpoints Apr 30, 2024
@andrewhare
Copy link
Contributor Author

@troian This PR will now contain all gRPC endpoint changes.

@andrewhare andrewhare self-assigned this May 1, 2024
@andrewhare
Copy link
Contributor Author

@troian This is ready for final review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port REST handlers to gRPC
1 participant