Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is probably still incomplete and requires more testing, so maybe keep in another branch until ready. In short, the consequential changes:
HiCPlotter.py
. Should have no effect on windows.__future__
importsxrange
replaced withrange
for line in file.xreadlines()
replaced withfor line in file:
max
incmatrix = log2(pow(2, ceil(log2(max(matrix))/log2(2))))
replaced withnp.nanmax
Issues that will probably arise will involve integer division and incompatibility of comparing objects of different types (e.g. int > list). Other hangups can most likely be resolved with the six package.
Style-wise, the changes are:
EDIT: oh, and also, fixed the default end point for read_Cooldata to
end = c.chromsizes[chrom]
, as we discussed :P