Make the layout sensible #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
symbiogenesis
force-pushed
the
sensible-layout
branch
2 times, most recently
from
05019ff to
41de827
Compare
symbiogenesis
force-pushed
the
sensible-layout
branch
5 times, most recently
from
cc31ef2 to
3fcdda5
Compare
symbiogenesis
force-pushed
the
sensible-layout
branch
from
3fcdda5 to
de7044b
Compare
symbiogenesis
changed the title
symbiogenesis
force-pushed
the
sensible-layout
branch
7 times, most recently
from
b7a6f1e to
ee05ea7
Compare
symbiogenesis
force-pushed
the
sensible-layout
branch
from
ee05ea7 to
200ca0c
Compare
symbiogenesis
changed the title
symbiogenesis
changed the title
symbiogenesis
force-pushed
the
sensible-layout
branch
from
a06a248 to
3be7574
Compare
symbiogenesis
force-pushed
the
sensible-layout
branch
from
bea8ce1 to
af6cc33
Compare
symbiogenesis
changed the title
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original way that the grid worked involved creating borders between cells by creating empty space, and then using the background color as the border color. That approach is quite counter-intuitive.
This PR wraps all of the cells with their own border. Now everything is way easier to understand for both users and developers.
Fixes #120