call Reload after DataGrid Loaded to fix initialization #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OnColumnsChanged event is already being listened and it calls the method. Can't see a way that the scenario might occur. @symbiogenesis could you please have a look? |
Co-authored-by: Ebu Akgul <[email protected]>
Looking at this now. |
|
This PR looks good. Some of the recent performance refactoring must have caused this regression. After merging, I will do some minor renaming and refactoring to help make things clearer. |
|
@akgulebubekir, you could push out another hotfix now if you like. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Reload method gets called approximately five times, but always before the DataGrid is loaded. As a result, some events were not initialized correctly. In the provided example project, the WonColumnVisible did not trigger an update. It was only after a ColumnChangeEvent (for instance, when a column was added or removed) that the Reload method was executed, and from that point on, the WonColumnVisible behavior started working as expected.