fix: stream leak in akka-http client backend for indefinite server st… #1833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanandren
reviewed
Sep 11, 2023
There was a problem hiding this comment.
Thanks, would be good with test coverage.
Could be added in interop-tests and have a client and server where the server closes over a promise, uses .watchTermination on the response stream to complete the promise and future.failed.futureValue as assert in the test case to wait for client cancelation to be seen on the server side.
|
I've pushed a test that I have verified locally fails on main and passes with your fix. |
johanandren
force-pushed
the
fix-akka-http-backend-stream-leak
branch
from
e8b4937 to
86e481f
Compare
|
Great, thank you. Next time I submit a PR, I will try to provide an appropriate test as well. |
|
fixed a Scala 3 compilation error in the test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1832