docs: First iteration of active-active guide steps #876

johanandren · 2023-04-25T14:58:01Z

No description provided.

patriknw

looking good

akka-distributed-cluster-docs/src/main/paradox/guide/3-active-active.md

patriknw

looking good

patriknw · 2023-04-27T14:49:43Z

akka-distributed-cluster-docs/src/main/paradox/guide/3-active-active.md

-Because of this the data structure must always arrive at the same state even if events arrive in a different order. To handle 
-this in the shopping cart we replace the `ItemAdded` and `ItemRemoved` events with a single `ItemUpdated` event
+Because of this the data structure must always arrive at the same state even if events arrive in a different order. We have
+already prepared for this somewhat by representing both add and remove using a single `ItemUpdated` event


Having a single event is not really a requirement for RES so I'm not sure about this explanation. The previous problem was the validation that Add could only be once, and then Adjust.

Another thing, do we need to clarify that events from a certain replica are always ordered? It's not that events are completely randomly ordered, there are some happens-before rules. Would maybe be too much detail here?

It was more my thought process of aligning the samples that leaked into the text than something actually requird, it was either pulling add/remove in here or the other way around. I'll see about making that more concise/correct.

I think talking about same-order from same replica would be to low level here, we already cover that in the Akka docs https://doc.akka.io/docs/akka/current/typed/replicated-eventsourcing.html#causal-delivery-order

Hopefully better now b7a4f5a

patriknw · 2023-04-27T14:57:56Z

samples/grpc/shopping-cart-service-java/src/main/java/shopping/cart/PublishEvents.java

-    return shopping.cart.proto.ItemRemoved.newBuilder()
-        .setCartId(itemRemoved.cartId)
-        .setItemId(itemRemoved.itemId)
+        .setCartId(PersistenceId.extractEntityId(envelope.persistenceId()))


Why change this? We still have the cartId in the event, and I think that is a pretty good practise to include the id in the event even though it technically can be extracted from the envelope like this.

ah, it was removed from the "internal" events but still in the external protobuf event.
That seems good, and also illustrates something that the transformation can handle different representations.

Yes, I think that the cart id was only included in the events to be able to pass it in the events published by the gRPC projection but that is now possible with the envelope transform without having to tweak the ES events just for the projection capability.

patriknw · 2023-04-27T15:00:50Z

samples/grpc/shopping-cart-service-java/src/main/java/shopping/cart/ShoppingCart.java

-        items.put(itemId, quantity);
-      }
+      int newQuantity = items.getOrDefault(itemId, 0) + quantity;
+      items.put(itemId, newQuantity);


is there a reason why we put 0 items, and then filter in other places? could it remove here instead if 0?

That was mostly to keep it roughly the same with the RES version, we could remove instead here since it is a more natural design for non RES.

I don't see a reason why it can't remove also in RES

If add 1, remove 1, add 1, remove 1 wold reordered to add 1, remove 1, remove 1, add 1 we get different end results with RES?

Back to removing non-present in grpc projection samples in db20600

johanandren · 2023-04-28T12:10:15Z

@patriknw I added opt in vip-replication to the Scala RES sample, but it requires an extra onlyReplicateVip flag on the cart to know if coordinated check out is needed or not, I can't decide if that is too messy for the guide or not, what do you think? (didn't add anything to the docs about it yet)

patriknw · 2023-04-28T12:31:04Z

I think that is fine. We are using the same sample to illustrate two different things and that's why it's not as clean as we may want, but don't see a good alternative right now.

…n CI

patriknw

I have read the full guide steps and I think it's looking good. Some minor comments...

akka-distributed-cluster-docs/src/main/paradox/guide/1-event-sourced-shopping-cart.md

akka-distributed-cluster-docs/src/main/paradox/guide/2-service-to-service.md

patriknw · 2023-05-02T14:17:18Z

akka-distributed-cluster-docs/src/main/paradox/guide/1-event-sourced-shopping-cart.md

@@ -34,15 +34,26 @@ Java



The State has customerId and customerCategory. First I thought that was for the RES filter, but I think that is vipCustomer?

Leftover from something that was before, I missed out on dropping it on the Scala side. We sort of re-introduce category in the RES sample for filtering but I made that a boolean for simplicity. Fixed in 4dd9c03

patriknw · 2023-05-02T14:18:13Z

akka-distributed-cluster-docs/src/main/paradox/guide/3-active-active.md

+    curl http://localhost:9201/ready
+    ```
+
+6. Try it with [grpcurl](https://github.com/fullstorydev/grpcurl):


something wrong with the rendering from step 6

Ah, missing block end, fixed 7de94a4

Co-authored-by: Patrik Nordwall <[email protected]>

patriknw

LGTM

octonato

Looking good. I only reviewed the Markdown files though.

I left some suggestions. Mostly commas.

akka-distributed-cluster-docs/src/main/paradox/guide/1-event-sourced-shopping-cart.md

akka-distributed-cluster-docs/src/main/paradox/guide/3-active-active.md

Co-authored-by: Renato Cavalcanti <[email protected]>

patriknw · 2023-05-05T06:35:27Z

test fail was #834 (comment), which seems to be flaky since before

patriknw reviewed Apr 25, 2023

View reviewed changes

patriknw reviewed Apr 27, 2023

View reviewed changes

johanandren added 9 commits May 2, 2023 12:28

docs: First iteration of active-active guide steps

2e9fb10

Smaller text changes

2c1125a

Align projection and RES sample event types, include testing sample i…

a77bb72

…n CI

Drop customer id and category in grpc sample, not used

6d41c32

optional replication only for vip

cc8d767

VIP producer filter to Java RES sample

dc14082

go back to removing non-present items in grpc carts

b153cb9

better filter docs

de284a3

Ups, missed the snippet anchors

3ab5cb4

johanandren force-pushed the wip-active-active-guide-page branch from 1a1b66b to 3ab5cb4 Compare May 2, 2023 10:28

A round over all guide sections, still missing stuff in deploy section

81a9444

johanandren marked this pull request as ready for review May 2, 2023 13:33

patriknw reviewed May 2, 2023

View reviewed changes

johanandren and others added 3 commits May 2, 2023 20:48

More unused cart state

4dd9c03

Missing block end

7de94a4

Apply suggestions from code review

13a1e3e

Co-authored-by: Patrik Nordwall <[email protected]>

patriknw approved these changes May 3, 2023

View reviewed changes

octonato reviewed May 3, 2023

View reviewed changes

commas etc

6ed5cdb

Co-authored-by: Renato Cavalcanti <[email protected]>

johanandren merged commit 865d3ab into main May 5, 2023

johanandren deleted the wip-active-active-guide-page branch May 5, 2023 06:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs: First iteration of active-active guide steps #876

docs: First iteration of active-active guide steps #876

johanandren commented Apr 25, 2023

patriknw left a comment

patriknw left a comment

patriknw Apr 27, 2023

johanandren Apr 27, 2023 •

edited

Loading

johanandren Apr 28, 2023

patriknw Apr 27, 2023

patriknw Apr 27, 2023

johanandren Apr 27, 2023

patriknw Apr 27, 2023

johanandren Apr 27, 2023

patriknw Apr 27, 2023

johanandren Apr 27, 2023

johanandren Apr 28, 2023

johanandren commented Apr 28, 2023 •

edited

Loading

patriknw commented Apr 28, 2023

patriknw left a comment

patriknw May 2, 2023

johanandren May 2, 2023

patriknw May 2, 2023

johanandren May 2, 2023

patriknw left a comment

octonato left a comment

patriknw commented May 5, 2023

docs: First iteration of active-active guide steps #876

docs: First iteration of active-active guide steps #876

Conversation

johanandren commented Apr 25, 2023

patriknw left a comment

Choose a reason for hiding this comment

patriknw left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

johanandren Apr 27, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

johanandren commented Apr 28, 2023 • edited Loading

patriknw commented Apr 28, 2023

patriknw left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

patriknw left a comment

Choose a reason for hiding this comment

octonato left a comment

Choose a reason for hiding this comment

patriknw commented May 5, 2023

johanandren Apr 27, 2023 •

edited

Loading

johanandren commented Apr 28, 2023 •

edited

Loading