Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Akka.TestKit dependency to 1.5.30 + Akka.TestKit.NUnit package to 1.5.30 #143

Merged
merged 3 commits into from
Oct 15, 2024
Merged

Bump Akka.TestKit dependency to 1.5.30 + Akka.TestKit.NUnit package to 1.5.30 #143

merged 3 commits into from
Oct 15, 2024

Conversation

milang
Copy link
Contributor

@milang milang commented Oct 11, 2024 •
edited
Loading

Changes

This pull request bumps Akka.TestKit dependency to version 1.5.30 and removes the preview version I introduced in #136 (where Akka.TestKit.NUnit was published as 1.6.0-preview.1). Instead, both Akka.TestKit.NUnit and Akka.TestKit.NUnit3 NuGet packages use the same version as Akka.TestKit, 1.5.30.

Checklist

dependabot bot and others added 3 commits October 4, 2024 11:38
@dependabot
Bump Akka.TestKit from 1.5.28 to 1.5.30
14d3033 
Bumps [Akka.TestKit](https://github.com/akkadotnet/akka.net) from 1.5.28 to 1.5.30.
- [Release notes](https://github.com/akkadotnet/akka.net/releases)
- [Changelog](https://github.com/akkadotnet/akka.net/blob/dev/RELEASE_NOTES.md)
- [Commits](akkadotnet/akka.net@1.5.28...1.5.30)

---
updated-dependencies:
- dependency-name: Akka.TestKit
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@milang
Synchronize version with Akka.TestKit 1.5.30
a0e7a2e
@milang
Update release notes for version 1.5.30
4294f91
@milang
Copy link
Contributor Author

milang commented Oct 11, 2024

@Aaronontheweb this is a follow-up to my comments from the previous PR (you were probably not notified because I posted them after the PR was merged and closed).

Important - because Akka.TestKit.NUnit now depends on NUnit 4, it can no longer be used in projects that still have to use NUnit 3. I recommend that you also publish Akka.TestKit.NUnit3 as built by this pull request (i.e. version 1.5.30). This will allow projects that use NUnit 3 to target the latest Akka.NET.

Akka.TestKit.NUnit3 currently available from Microsoft NuGet registry is at version 1.3.8, which is quite dated. The deprecation message "... please use Akka.TestKit.NUnit (which also supports NUnit3)" made sense up to version 1.5.24, but doesn't make sense now that Akka.testKit.NUnit no longer supports NUnit 3.

image

@milang
Copy link
Contributor Author

milang commented Oct 15, 2024

@Aaronontheweb any feedback for the PR?

@Aaronontheweb
Copy link
Member

Sorry @milang - this looks good to me

@Aaronontheweb Aaronontheweb merged commit f86c753 into akkadotnet:dev Oct 15, 2024
2 checks passed
@milang milang deleted the fix-version branch October 15, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@milang @Aaronontheweb