Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/cancellable-queries #80

Merged
merged 3 commits into from
Jan 12, 2024
Merged

Fix/cancellable-queries #80

merged 3 commits into from
Jan 12, 2024

Conversation

einari
Copy link
Contributor

@einari einari commented Jan 10, 2024

Fixed

  • Fixing so that if a client fetches from the same query multiple times and the response could potentialle come out of order, we make sure to cancel any ongoing requests.
  • Adding a cancellation token for ObservableClient queries that we pass along to every WebSocket operation in case the client disconnects.

…id sending things to the client after it is disconnected
…, so that we guarantee order of result from query calls
@einari einari added the patch label Jan 10, 2024
@einari einari merged commit c662dc8 into main Jan 12, 2024
5 checks passed
@einari einari deleted the fix/cancellable-queries branch January 12, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant