-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(directives): git-overwrite
-> git-clear
#2643
Conversation
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for docs-kargo-akuity-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2643 +/- ##
==========================================
+ Coverage 51.02% 51.04% +0.01%
==========================================
Files 282 282
Lines 21121 21092 -29
==========================================
- Hits 10778 10766 -12
+ Misses 9658 9644 -14
+ Partials 685 682 -3 ☔ View full report in Codecov by Sentry. |
@hiddeco can you update the name here as well? On a side-note, do you have a better way to bundle built-in registries for accurate UI discovery mechanism? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 Agree this is a huge improvement. I will update my docs-in-progress accordingly.
Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
27afeb2
to
0ebcbe1
Compare
Not completely sure I follow your question, but is your goal to e.g. gain access to the JSON schemas — or do you want to be able to discover any arbitrary directive that is available? |
any directive that is available. Basically some mechanism, that prevents the necessity to update UI code for any modification in directive registry. I think we can tackle this later on when we make directives pluggable, for now hardcoding it in UI is fine |
I put some thought into this the other night. I think it very likely that plugins will be registered using a plugin registration CRD. We'll make sure there is an API endpoint that can list those so the UI can learn everything it needs to about available directives. For now, hard coded is fine. |
Signed-off-by: Hidde Beydals <[email protected]> (cherry picked from commit 609a937)
Successfully created backport PR for |
After dog feeding, it became apparent that the more natural way of this directive would be to clear a Git branch from contents before running e.g.
kustomize-build
.By doing this, the previous ("rendered branch") flow of:
source
andtarget
output/
output/
totarget/
Changes to:
source
andtarget
target
target
Effectively causing there to be one directory less to deal with.