Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(controller): fix slice init length #2648

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Conversation

cuishuang
Copy link
Contributor

The intention here should be to initialize a slice with a capacity of length rather than initializing the length of this slice.

The online demo: https://go.dev/play/p/q1BcVCmvidW

@cuishuang cuishuang requested a review from a team as a code owner October 4, 2024 11:02
Copy link

netlify bot commented Oct 4, 2024

Deploy Preview for docs-kargo-akuity-io canceled.

Name Link
🔨 Latest commit e112869
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/67000802475eb800084ce058

Copy link

netlify bot commented Oct 4, 2024

Deploy Preview for docs-kargo-io ready!

Name Link
🔨 Latest commit e112869
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-io/deploys/67000802591eaf00087f58ef
😎 Deploy Preview https://deploy-preview-2648--docs-kargo-io.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

internal/argocd/health.go Outdated Show resolved Hide resolved
@krancour krancour added this to the v0.9.0 milestone Oct 4, 2024
@krancour krancour modified the milestones: v0.9.0, v1.0.0 Oct 4, 2024
@krancour krancour changed the title fix: fix slice init length refactor(controller): fix slice init length Oct 4, 2024
@krancour
Copy link
Member

krancour commented Oct 4, 2024

Thank you @cuishuang!

@krancour krancour self-requested a review October 4, 2024 16:31
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.09%. Comparing base (cdec347) to head (e112869).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2648      +/-   ##
==========================================
+ Coverage   51.04%   51.09%   +0.05%     
==========================================
  Files         282      282              
  Lines       21092    21121      +29     
==========================================
+ Hits        10766    10792      +26     
- Misses       9644     9646       +2     
- Partials      682      683       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krancour krancour added this pull request to the merge queue Oct 4, 2024
Merged via the queue into akuity:main with commit 4b19a86 Oct 4, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants