first pass at a garbage collector #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kent <[email protected]>
Signed-off-by: Kent <[email protected]>
Signed-off-by: Kent <[email protected]>
krancour
requested review from
alexmt,
devholic,
gdsoumya,
jessesuen,
kencochrane and
rbreeze
as code owners
✅ Deploy Preview for docs-kargo-akuity-io canceled.
|
Codecov Report
@@ Coverage Diff @@
## main #481 +/- ##
==========================================
+ Coverage 49.70% 51.18% +1.47%
==========================================
Files 50 51 +1
Lines 3947 4085 +138
==========================================
+ Hits 1962 2091 +129
- Misses 1902 1910 +8
- Partials 83 84 +1
|
devholic
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #401
This is a minimally viable and minimally configurable garbage collector component:
Schedule is configurable. Defaults to the top of each hour.
The number of goroutines is configurable. Too low and GC is slow. Too high and the k8s API server throttles us. Defaults to 3.
The maximum number of Promotions in terminal states to be retained per Project. Promotions in non-terminal phases are never deleted regardless of this limit. Defaults to 20.
There is no support at this time for defining retention limits individually at the Project or Stage level.