Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.

Feature/move to typescript #153

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

tachyon-ops
Copy link

@tachyon-ops tachyon-ops commented Feb 23, 2022

  • Moves code base to typescript
  • Adds vue example (./example)
  • Adds react example (./example_react)

Todo:

  • Check tests
  • Test Vue and setup vue in react in example_react which was not done
  • Check what's missing
  • Check unpkg (do we really need it?)

@tachyon-ops
Copy link
Author

Ping @cwadrupldijjit

@cwadrupldijjit
Copy link
Collaborator

I briefly checked over everything in the PR. Still might need a little time to grok.

I noticed that the Travis CI integration didn't send any response back, but I'm not sure how to get to that yet. I'll have to look into it more.

Switching things over to TypeScript is looking good so far. I'm probably going to have to check everything out on my own before I can say either way. Having TypeScript support is definitely going to make life easier for anybody who consumes it but can also be quite nice for maintaining it.

For the items in the todo checklist, I can address those in a minute, but I can't focus on this for too much longer today. I'll try to address them before the end of the week.

@tachyon-ops
Copy link
Author

tachyon-ops commented Mar 3, 2022

@cwadrupldijjit Just let me know if you need further help :)

Be aware I have edited the Todo list topic: Test Vue and setup vue in react in example_react which was not done

@tachyon-ops tachyon-ops mentioned this pull request Apr 28, 2022
@tachyon-ops
Copy link
Author

It is a pity this was never pursued by vuera maintainers... :/

@cwadrupldijjit
Copy link
Collaborator

Truth be told, I've had a hectic year since I really sat down and looked at this project. My job, where I had been thinking to use this package, was cut short unexpectedly and I was scrambling to find another job. As such, life for me has been trying to stabilize well enough to focus on the open-source projects I'm connected with.

I have my own branch on this repo that I had been changing locally to work with TypeScript and address some of the other issues listed here, but because of said loss of job, I let it collect dust because other things became a higher priority.

However, I plan to test this out again and see what I think. I also figure that the dependencies/peer dependencies might need some refreshing. I also have been researching ways to make sure this translation layer between React and Vue is more seamless and could potentially include better feature support between the two.

As such, I'm really sorry I've been distracted by life over this PR and repo, but I do plan to return to this project and be a better maintainer.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants