Commits on Mar 22, 2024

1. Fix incorrect results with multiple COUNT(DISTINCT..) aggregates on… …

   … dictionaries (apache#9679)
   
   * Add test for multiple count distincts on a dictionary
   
   * Fix accumulator merge bug
   
   * Fix cleanup code

   

   alamb committed Mar 22, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 9c30505
   • Browse repository at this point

   Copy the full SHA

   9c30505 View commit details

   Browse the repository at this point in the history

2. fix(9678): short circuiting prevented population of visited stack, fo… …

   …r common subexpr elimination optimization (apache#9685)
   
   * test(9678): reproducer of short-circuiting causing expr elimination to error
   
   * fix(9678): populate visited stack for short-circuited expressions, during the common-expr elimination optimization
   
   * test(9678): reproducer for optimizer error (in common_subexpr_eliminate), as seen in other test case
   
   * chore: extract id_array into abstraction, to make it more clear the relationship between the two visitors
   
   * refactor: tweak the fix and make code more explicit (JumpMark, node_to_identifier)
   
   * fix: get the series_number and curr_id with the correct self.current_idx, before the various incr/decr
   
   * chore: remove unneeded conditional check (already done earlier), and add code comments
   
   * Refine documentation in common_subexpr_eliminate.rs
   
   * chore: cleanup -- fix 1 doc comment and consolidate common-expr-elimination test with other expr test
   
   ---------
   
   Co-authored-by: Andrew Lamb <[email protected]>

   

   wiedld and alamb committed Mar 22, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 4aa4f05
   • Browse repository at this point

   Copy the full SHA

   4aa4f05 View commit details

   Browse the repository at this point in the history