Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "stardist" model and datasource for scivision catalog #429

Merged
merged 13 commits into from
Jan 10, 2023

Conversation

edwardchalstrey1
Copy link
Contributor

@edwardchalstrey1 edwardchalstrey1 commented Nov 18, 2022

Hi @mooniean - I am in the process of updating scivision model/datasource entries for the catalog/website, can you help me with the following?

  1. I assume as this is cell bio you know the authors? If you can't answer the below yourself, could you tag the GH account of the contact who we got this from?
  2. Can you confirm the model and dataset thumbnail images are appropriate
  3. Can you confirm the descriptions are appropriate?
  4. Is there a better name we could give the datasource?
  5. Are there any scivision notebooks where stardist data or model are loaded that would break as a result of these name changes? I assume not, since the model is not currently loadable via the Python package.

TODO:

See the screenshots below for what this looks like in Scivision

@edwardchalstrey1
Copy link
Contributor Author

edwardchalstrey1 commented Nov 18, 2022

Scivision model page

Screenshot 2022-11-18 at 10 16 22

Scivision datasources page

Screenshot 2022-11-18 at 10 16 15

@ots22
Copy link
Member

ots22 commented Nov 23, 2022

Currently the catalogs have a few older entries like this that point to repositories that aren’t set up as ‘scivision compatible’ models/datasets (without .scivision/ metadata).

We could write wrappers around these, which is probably the ideal outcome, but what should we do before that?

We could

  1. Leave them in the catalog
    • perhaps add a ‘has-scivision-metadata’ field to the catalog, indicating that they can’t be run or loaded automatically - or maybe just detecting the missing .scivision is enough. These could be visible in the frontend, but fail in the python library with a sensible message.
  2. Remove them for now
    • add them to a list of models/datasets we want/intend to include somewhere (perhaps 'good first issue' material)

(Similar slack discussion)

@edwardchalstrey1
Copy link
Contributor Author

Currently the catalogs have a few older entries like this that point to repositories that aren’t set up as ‘scivision compatible’ models/datasets (without .scivision/ metadata).

We could write wrappers around these, which is probably the ideal outcome, but what should we do before that?

We could

  1. Leave them in the catalog

    • perhaps add a ‘has-scivision-metadata’ field to the catalog, indicating that they can’t be run or loaded automatically - or maybe just detecting the missing .scivision is enough. These could be visible in the frontend, but fail in the python library with a sensible message.
  2. Remove them for now

    • add them to a list of models/datasets we want/intend to include somewhere (perhaps 'good first issue' material)

(Similar slack discussion)

yeah, in the frontend we could have a tag like scivision.py loadable

@mooniean
Copy link
Contributor

Somehow I missed the notification for this - I actually haven't worked with this, I believe it was @evangeline-corcoran

@edwardchalstrey1
Copy link
Contributor Author

Hi @evangeline-corcoran when you have a free moment would you be able to take a look at the questions I have listed in the top comment, no rush :)

@evangeline-corcoran
Copy link
Contributor

Hi @edwardchalstrey1

Please see my answers to the top comment questions below and let me know if you need any more info

> I assume as this is cell bio you know the authors? If you can't answer the below yourself, could you tag the GH account of the contact who we got this from?

The authors are Uwe Schmidt (uschmidt83), Martin Weigert (maweigert), Robert Haase (haesleinhuepf), and Ko Sugawara (ksugar). The stardist models and datasets are publicly available here: https://github.com/stardist/stardist

> Can you confirm the model and dataset thumbnail images are appropriate

Yes, these are good

> Can you confirm the descriptions are appropriate?

For the model I would suggest - "Single class object detection and segementation of star-convex polygons"

For the dataset - "Cell microscopy test dataset for detection and segmentation of individual nuclei"

> Is there a better name we could give the datasource?

Something like "StarDist cell nuclei 2D" as they also have a dataset of synthetic 3D cell images

> Are there any scivision notebooks where stardist data or model are loaded that would break as a result of these name changes? I assume not, since the model is not currently loadable via the Python package.

No

@edwardchalstrey1
Copy link
Contributor Author

Hi @uschmidt83 @maweigert @haesleinhuepf @ksugar - we're currently in the process of upgrading the Scivision project and included datasets/models with a new website available at https://sci.vision - as a result of this we're updating some of the metadata for legacy models/datasources including your own that were added at an earlier stage of the project. Would one of you be able to review the proposed names, descriptions and thumbnails in this PR and let us know your thoughts?

In addition, we aim wherever possible to make inclusions to the scivision catalog loadable via the Python API. I can make this possible for your datasource, however I notice at the moment that the datasource url (https://github.com/stardist/stardist/releases/download/0.3.0/demo3D.zip) downloads a folder of both training and test images (and masks), but that the images appear to be blank? Perhaps I'm misunderstanding something about this data, but I was expecting images similar to thumbnail I added (I think taken from the model GitHub page). If possible, a folder of test images that are ready for the model to be run on would be good for inclusion in scivision.

Let me know your thoughts (and no rush on this). Thanks, Ed.

@edwardchalstrey1
Copy link
Contributor Author

I'm going to merge this PR now to get the thumbnail images in, but we can always change things at a later date if needed

@edwardchalstrey1 edwardchalstrey1 merged commit 04625ee into main Jan 10, 2023
@edwardchalstrey1 edwardchalstrey1 deleted the rename-stardist branch January 10, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants