add logic to parse correctly cookies on req #108
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Este PR agrega el fix para que podamos realmente parsear las cookies del request y podamos obtener el jwt de ahi. Tambien aprovecho y normalizo las keys a utilizar de las cookies asi no hay dudas cuales podemos usar.
Hoy tenemos 3 casos:
Por default y vamos a hacer la validacion primero de
si queremos cambiar las keys a comprobar (y su orden) simplemente usamos la nueva config de JWTOptions
cookiesKeys
. Ahi pasamos un array ordenados de keys a chequear para buscar un jwt. El primero que encuentra se usa.Si no se manda define como default
[JwtCookiesKeys.IMPERSONATED_ACCESS, JwtCookiesKeys.USER_ACCESS]
para respetar la logica default que explico arriba.Aprovecho y ya paso también el
parseCookie
por si lo tiene que usar alguien, ya que express no lo trae por defecto y asi usamos siempre la misma version.