Skip to content

Commit

Permalink
Hotfix
Browse files Browse the repository at this point in the history
  • Loading branch information
albertogeniola committed Jan 5, 2023
1 parent a99516c commit a3c1844
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0.4.5.6
0.4.5.7
7 changes: 5 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -190,11 +190,14 @@ Anyway, feel free to contribute via donations!
</p>

## Changelog
#### 0.4.5.4
- Fix #274, due to Meross API change
#### 0.4.5.7
- Fix regression introduced with the latest refactor: missing properties on SubDevices.

<details>
<summary>Older</summary>
#### 0.4.5.4
- Fix #274, due to Meross API change

#### 0.4.5.4-rc1
- Fix tests
- Implement auto-discovery control parameter for the `MerossManager`
Expand Down
11 changes: 9 additions & 2 deletions meross_iot/controller/device.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
from meross_iot.model.enums import OnlineStatus, Namespace
from meross_iot.model.http.device import HttpDeviceInfo
from meross_iot.model.plugin.hub import BatteryInfo
from meross_iot.model.shared import BaseDictPayload
from meross_iot.utilities.network import extract_domain, extract_port

_LOGGER = logging.getLogger(__name__)
Expand All @@ -24,9 +23,17 @@ class BaseDevice(object):
name, type (i.e. device specific model), firmware/hardware version, a Meross internal
identifier, a library assigned internal identifier.
"""
_name: str = "unknown"
_type: str = "unknown"
_fwversion: str = "unknown"
_hwversion: str = "unknown"
_online: OnlineStatus = OnlineStatus.UNKNOWN
_inner_ip: Optional[str] = None
_mqtt_host: str = DEFAULT_MQTT_HOST
_mqtt_port: int = DEFAULT_MQTT_PORT

def __init__(self, device_uuid: str,
manager, # TODO: type hinting "manager"
manager,
**kwargs):
self._uuid = device_uuid
self._manager = manager
Expand Down

0 comments on commit a3c1844

Please sign in to comment.