CI: add pypi package check #72
Conversation
partially addresses #62
|
our CI is not running on PRs so mainly I want to find out why |
Codecov Report
@@ Coverage Diff @@
## master #72 +/- ##
=======================================
Coverage 90.13% 90.13%
=======================================
Files 11 11
Lines 152 152
Branches 19 19
=======================================
Hits 137 137
Misses 15 15
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
- run all supported on ubuntu-latest - only run macOS-latest on 2.7 and lowest/highest supported 3.x - only run windows-latest on 2.7 and lowest/highest supported 3.x
|
@xiki-tempula could you have a quick look? I'd like to merge soon, mostly to ensure that we have CI running because at the moment, other PRs such as #71 don't run tests. |
| @@ -26,14 +26,23 @@ jobs: | |||
| os: [macOS-latest, ubuntu-latest, windows-latest] | |||
| python-version: ["2.7", "3.5", "3.6", "3.7", "3.8", "3.9", "3.10"] | |||
There was a problem hiding this comment.
python-version: ["3.7", "3.8", "3.9", "3.10"]
There was a problem hiding this comment.
We can do NEP29 for alchemtest but to be honest, as long as it works I'm ok with just testing on supported platforms.
If you want to follow NEP29, open an issue.
This PR does not really check that all files are included. It only checks that we can build the sdist. We'd need to build the package, install, run tests for the installed package. Not very difficult but just more than I have time for right now. |
orbeckst
force-pushed
the
ci-check-package
branch
from
736135d
to
6adcd88
Compare
partially addresses #62