-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NEP29 #76
NEP29 #76
Conversation
Codecov Report
@@ Coverage Diff @@
## master #76 +/- ##
=======================================
Coverage 99.34% 99.34%
=======================================
Files 11 11
Lines 152 152
Branches 19 18 -1
=======================================
Hits 151 151
Misses 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the documentation, too.
@orbeckst @DrDomenicoMarson is using pathlib for the path related operations in #71, so it is good to deprecate the versions that do not support pathlib. I wonder when you say documentation, what do you mean? I have searched the 2.7 and cannot find more hits. |
Add a note to the docs that states that we follow NEP29, pretty much the same as in the alchemlyb docs that I linked in #77 |
@orbeckst Right. I have added the secion to index.rst saying that we will adopt NEP29 from 0.8.0 |
Remove support for py<3.7.