Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEP29 #76

Merged
merged 2 commits into from
Oct 9, 2022
Merged

NEP29 #76

merged 2 commits into from
Oct 9, 2022

Conversation

xiki-tempula
Copy link
Collaborator

Remove support for py<3.7.

@codecov
Copy link

codecov bot commented Oct 1, 2022

Codecov Report

Merging #76 (8a97305) into master (c574471) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #76   +/-   ##
=======================================
  Coverage   99.34%   99.34%           
=======================================
  Files          11       11           
  Lines         152      152           
  Branches       19       18    -1     
=======================================
  Hits          151      151           
  Misses          1        1           
Flag Coverage Δ
unittests 99.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the documentation, too.

@orbeckst orbeckst mentioned this pull request Oct 1, 2022
@orbeckst orbeckst linked an issue Oct 1, 2022 that may be closed by this pull request
@xiki-tempula
Copy link
Collaborator Author

@orbeckst @DrDomenicoMarson is using pathlib for the path related operations in #71, so it is good to deprecate the versions that do not support pathlib.

I wonder when you say documentation, what do you mean? I have searched the 2.7 and cannot find more hits.

@orbeckst
Copy link
Member

orbeckst commented Oct 1, 2022

Add a note to the docs that states that we follow NEP29, pretty much the same as in the alchemlyb docs that I linked in #77

@xiki-tempula
Copy link
Collaborator Author

@orbeckst Right. I have added the secion to index.rst saying that we will adopt NEP29 from 0.8.0

@orbeckst orbeckst self-assigned this Oct 9, 2022
@orbeckst orbeckst merged commit 57458ef into alchemistry:master Oct 9, 2022
@xiki-tempula xiki-tempula deleted the feat_py37 branch October 9, 2022 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

adopt NEP29
2 participants