test(test-d): add test-d files for vitest typechecking: #1248

Blu-J · 2024-12-20T15:31:22Z

Pull Request Checklist

Did you add new tests and confirm existing tests pass? (yarn test)
Did you update relevant docs? (docs are found in the site folder, and guidelines for updating/adding docs can be found in the contribution guide)
Do your commits follow the Conventional Commits standard?
Does your PR title also follow the Conventional Commits standard?
If you have a breaking change, is it correctly reflected in your commit message? (e.g. feat!: breaking change)
Did you run lint (yarn lint:check) and fix any issues? (yarn lint:write)
Did you follow the contribution guidelines?

PR-Codex overview

This PR primarily focuses on enhancing type-checking and testing configurations across various packages, while also removing unnecessary code related to AlchemyTransport. It introduces new test files and updates existing tests to ensure better type safety and code quality.

Detailed summary

Added test-d.ts files for improved type-checking.
Updated package.json files to exclude .test.ts and include .test-d.ts.
Modified CI workflow to include type-checking tests.
Enhanced CONTRIBUTING.md to reflect new testing practices.
Removed AlchemyTransport related code from client.test.ts.
Added new tests in client.test-d.ts for type assertions.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

vercel · 2024-12-20T15:31:25Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
aa-sdk-site	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 10, 2025 5:32pm
aa-sdk-ui-demo	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 10, 2025 5:32pm

Blu-J · 2024-12-20T15:31:38Z

How to use the Graphite Merge Queue

Add the label graphite-merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

Blu-J · 2024-12-20T15:40:28Z

.github/workflows/on-pull-request.yml

@@ -102,3 +102,6 @@ jobs:
      - name: Unit Test
        run: yarn test:ci

+      - name: Typecheck Test


We want to make sure that during the run we test our new function

Blu-J · 2024-12-20T15:41:14Z

.vitest/vitest.shared.ts

@@ -3,6 +3,11 @@ import { configDefaults, defineConfig } from "vitest/config";

 export const sharedConfig = defineConfig({
  test: {
+    typecheck: {
+      enabled: process.env.TYPECHECK === "true",


So using a ENV because I should have been able to pass this as an argument to the vitest.
After hours of it not working, I did this env and it just works. So 🤷‍♀️

Blu-J · 2024-12-20T15:42:35Z

.vitest/vitest.shared.ts

+    typecheck: {
+      enabled: process.env.TYPECHECK === "true",
+      only: process.env.TYPECHECK === "true",
+      ignoreSourceErrors: true,


When testing, files that just don't typecheck, ie the multisig account
Will fail this step without this set as true

Ah we should just exclude this file from the test sets since later we'll delete this file. That way the other tests can at least get caught as well. We've had cases where code built no prob but it ruined some branch of the types and we didn't notice cuz the tests don't get type checked

They already are excluded in the tests btw, just the typecheck will check non test files that are excluded.

Blu-J · 2024-12-20T15:43:08Z

aa-sdk/core/package.json

@@ -17,6 +17,7 @@
    "!vitest.config.ts",
    "!.env",
    "!src/**/*.test.ts",
+    "!src/**/*.test-d.ts",


Anyplace that I found .test.ts I add the test-dvariant

vercel · 2024-12-20T16:33:56Z

You must have Developer access to commit code to Alchemy on Vercel. If you contact an administrator and receive Developer access, commit again to see your changes.

Learn more: https://vercel.com/docs/accounts/team-members-and-roles/access-roles#team-level-roles

graphite-app · 2024-12-20T17:14:34Z

Merge activity

Dec 20, 12:14 PM EST: A user added this pull request to the Graphite merge queue.
Jan 7, 11:31 AM EST: The Graphite merge queue removed this pull request due to removal of a downstack PR #1236.
Jan 10, 12:18 PM EST: A user added this pull request to the Graphite merge queue.
Jan 10, 12:34 PM EST: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (PR does not have required approvals).
Jan 10, 3:43 PM EST: A user added this pull request to the Graphite merge queue.
Jan 10, 3:44 PM EST: A user merged this pull request with the Graphite merge queue.

# Pull Request Checklist - [x] Did you add new tests and confirm existing tests pass? (`yarn test`) - [x] Did you update relevant docs? (docs are found in the `site` folder, and guidelines for updating/adding docs can be found in the [contribution guide](https://github.com/alchemyplatform/aa-sdk/blob/main/CONTRIBUTING.md)) - [x] Do your commits follow the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) standard? - [x] Does your PR title also follow the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) standard? - [x] If you have a breaking change, is it [correctly reflected in your commit message](https://www.conventionalcommits.org/en/v1.0.0/#examples)? (e.g. `feat!: breaking change`) - [x] Did you run lint (`yarn lint:check`) and fix any issues? (`yarn lint:write`) - [x] Did you follow the [contribution guidelines](https://github.com/alchemyplatform/aa-sdk/blob/main/CONTRIBUTING.md)?  --- ## PR-Codex overview This PR focuses on enhancing type checking and testing for the `account-kit` packages, particularly by adding `test-d.ts` files and updating test commands. It also removes unused code related to Alchemy transport. ### Detailed summary - Added `test-d.ts` files for type definitions in multiple packages. - Updated `.github/workflows/on-pull-request.yml` to include type checking in tests. - Modified `package.json` to add a new `test:typecheck` script. - Updated `CONTRIBUTING.md` to reflect changes in testing commands. - Removed Alchemy-related code from `client.test.ts`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

The base branch was changed.

Blu-J mentioned this pull request Dec 20, 2024

feat(aa-sdk): sdk light client can call the alchemy client #1236

Merged

7 tasks

Blu-J marked this pull request as ready for review December 20, 2024 15:32

Blu-J requested review from moldy530, rthomare, dancoombs, mokok123, dphilipson and linnall as code owners December 20, 2024 15:32

vercel bot had a problem deploying to Preview – aa-sdk-ui-demo December 20, 2024 15:33 Failure

vercel bot deployed to Preview – aa-sdk-site December 20, 2024 15:36 View deployment

Blu-J commented Dec 20, 2024

View reviewed changes

moldy530 previously approved these changes Dec 20, 2024

View reviewed changes

Blu-J force-pushed the 12-20-test_test-d_add_test-d_files_for_vitest_typechecking_ branch from d97b716 to 6269d09 Compare December 20, 2024 16:33

Blu-J force-pushed the 12-20-test_test-d_add_test-d_files_for_vitest_typechecking_ branch from 6269d09 to 5374388 Compare December 20, 2024 17:02

vercel bot deployed to Preview – aa-sdk-ui-demo December 20, 2024 17:11 View deployment

vercel bot deployed to Preview – aa-sdk-site December 20, 2024 17:12 View deployment

Blu-J mentioned this pull request Jan 7, 2025

feat(client): multi account light and alchemy consolidation #1264

Merged

7 tasks

Blu-J force-pushed the jade/poc-same-client branch from cca9ba3 to e7bcc56 Compare January 7, 2025 16:37

Blu-J requested review from adamegyed, howydev, Zer0dot and jaypaik as code owners January 7, 2025 16:37

Blu-J force-pushed the 12-20-test_test-d_add_test-d_files_for_vitest_typechecking_ branch from 5374388 to 80c1c59 Compare January 7, 2025 16:37

vercel bot deployed to Preview – aa-sdk-ui-demo January 7, 2025 16:49 View deployment

vercel bot deployed to Preview – aa-sdk-site January 7, 2025 16:52 View deployment

Blu-J force-pushed the jade/poc-same-client branch from e7bcc56 to 939f24e Compare January 8, 2025 18:57

Blu-J force-pushed the 12-20-test_test-d_add_test-d_files_for_vitest_typechecking_ branch from 80c1c59 to 50c2618 Compare January 8, 2025 18:57

vercel bot deployed to Preview – aa-sdk-ui-demo January 8, 2025 19:09 View deployment

vercel bot deployed to Preview – aa-sdk-site January 8, 2025 19:12 View deployment

Blu-J force-pushed the jade/poc-same-client branch from 939f24e to a0fdd71 Compare January 8, 2025 21:31

Blu-J force-pushed the 12-20-test_test-d_add_test-d_files_for_vitest_typechecking_ branch from 50c2618 to d973a94 Compare January 8, 2025 21:32

vercel bot deployed to Preview – aa-sdk-ui-demo January 8, 2025 21:43 View deployment

vercel bot deployed to Preview – aa-sdk-site January 8, 2025 21:45 View deployment

Blu-J force-pushed the jade/poc-same-client branch from a0fdd71 to 22a2e20 Compare January 9, 2025 22:46

Blu-J force-pushed the 12-20-test_test-d_add_test-d_files_for_vitest_typechecking_ branch from d973a94 to e0db87d Compare January 9, 2025 22:46

vercel bot deployed to Preview – aa-sdk-ui-demo January 9, 2025 22:57 View deployment

vercel bot deployed to Preview – aa-sdk-site January 9, 2025 23:00 View deployment

Blu-J force-pushed the jade/poc-same-client branch from 22a2e20 to cd9053b Compare January 10, 2025 17:19

Blu-J force-pushed the 12-20-test_test-d_add_test-d_files_for_vitest_typechecking_ branch from e0db87d to 21acc9f Compare January 10, 2025 17:19

vercel bot deployed to Preview – aa-sdk-ui-demo January 10, 2025 17:30 View deployment

vercel bot deployed to Preview – aa-sdk-site January 10, 2025 17:32 View deployment

Base automatically changed from jade/poc-same-client to main January 10, 2025 17:34

Blu-J mentioned this pull request Jan 10, 2025

feat: add alchemy transport update for the mav2 account client #1271

Draft

7 tasks

moldy530 approved these changes Jan 10, 2025

View reviewed changes

graphite-app bot merged commit 21acc9f into main Jan 10, 2025
8 checks passed

graphite-app bot deleted the 12-20-test_test-d_add_test-d_files_for_vitest_typechecking_ branch January 10, 2025 20:44

vercel bot deployed to Production – aa-sdk-ui-demo January 10, 2025 20:54 View deployment

vercel bot deployed to Production – aa-sdk-site January 10, 2025 20:57 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test(test-d): add test-d files for vitest typechecking: #1248

test(test-d): add test-d files for vitest typechecking: #1248

Blu-J commented Dec 20, 2024 •

edited by pr-codex bot

Loading

vercel bot commented Dec 20, 2024 •

edited

Loading

Blu-J commented Dec 20, 2024 •

edited

Loading

Blu-J Dec 20, 2024

Blu-J Dec 20, 2024

Blu-J Dec 20, 2024

Blu-J Dec 20, 2024

moldy530 Dec 20, 2024

Blu-J Dec 20, 2024

Blu-J Dec 20, 2024

vercel bot commented Dec 20, 2024

graphite-app bot commented Dec 20, 2024 •

edited

Loading

test(test-d): add test-d files for vitest typechecking: #1248

test(test-d): add test-d files for vitest typechecking: #1248

Conversation

Blu-J commented Dec 20, 2024 • edited by pr-codex bot Loading

Pull Request Checklist

PR-Codex overview

Detailed summary

vercel bot commented Dec 20, 2024 • edited Loading

Blu-J commented Dec 20, 2024 • edited Loading

How to use the Graphite Merge Queue

Blu-J Dec 20, 2024

Choose a reason for hiding this comment

Blu-J Dec 20, 2024

Choose a reason for hiding this comment

Blu-J Dec 20, 2024

Choose a reason for hiding this comment

Blu-J Dec 20, 2024

Choose a reason for hiding this comment

moldy530 Dec 20, 2024

Choose a reason for hiding this comment

Blu-J Dec 20, 2024

Choose a reason for hiding this comment

Blu-J Dec 20, 2024

Choose a reason for hiding this comment

vercel bot commented Dec 20, 2024

graphite-app bot commented Dec 20, 2024 • edited Loading

Merge activity

Blu-J commented Dec 20, 2024 •

edited by pr-codex bot

Loading

vercel bot commented Dec 20, 2024 •

edited

Loading

Blu-J commented Dec 20, 2024 •

edited

Loading

graphite-app bot commented Dec 20, 2024 •

edited

Loading