feat: add 7702 compatible semi modular account #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary by OctaneNew Contracts
Updated Contracts
🔗 Commit Hash: 024b620 |
|
Contract sizes: | Contract | Runtime Size (B) | Initcode Size (B) | Runtime Margin (B) | Initcode Margin (B) |
|-------------------------------|------------------|-------------------|--------------------|---------------------|
| AccountFactory | 5,921 | 6,386 | 18,655 | 42,766 |
| AllowlistModule | 9,553 | 9,580 | 15,023 | 39,572 |
| ExecutionInstallDelegate | 5,714 | 5,760 | 18,862 | 43,392 |
-| ModularAccount | 21,975 | 28,804 | 2,601 | 20,348 |
-| NativeFunctionDelegate | 560 | 587 | 24,016 | 48,565 |
+| ModularAccount | 21,975 | 28,678 | 2,601 | 20,474 |
+| NativeFunctionDelegate | 434 | 461 | 24,142 | 48,691 |
| NativeTokenLimitModule | 4,449 | 4,476 | 20,127 | 44,676 |
| PaymasterGuardModule | 1,845 | 1,872 | 22,731 | 47,280 |
-| SemiModularAccountBytecode | 23,358 | 30,187 | 1,218 | 18,965 |
-| SemiModularAccountStorageOnly | 23,852 | 30,681 | 724 | 18,471 |
+| SemiModularAccount7702 | 22,795 | 29,491 | 1,781 | 19,661 |
+| SemiModularAccountBytecode | 23,277 | 29,980 | 1,299 | 19,172 |
+| SemiModularAccountStorageOnly | 23,771 | 30,474 | 805 | 18,678 |
| SingleSignerValidationModule | 3,646 | 3,673 | 20,930 | 45,479 |
| TimeRangeModule | 2,000 | 2,027 | 22,576 | 47,125 |
| WebAuthnValidationModule | 7,854 | 7,881 | 16,722 | 41,271 |Code coverage:
|
Overview
Detailed findings
|
fangting-alchemy
force-pushed
the
7702
branch
from
1e1c931 to
29f57fe
Compare
jaypaik
changed the title
jaypaik
changed the title
Zer0dot
approved these changes
Nov 12, 2024
jaypaik
reviewed
Nov 12, 2024
| /// @notice An implementation of a semi-modular account which reads the signer as the address(this). | ||
| /// @dev Inherits SemiModularAccountBase. This account can be used as the delegate contract of an EOA with | ||
| /// EIP-7702, where address(this) (aka the EOA address) is the default fallback signer. | ||
| contract SemiModularAccount7702 is SemiModularAccountBase { |
There was a problem hiding this comment.
[Discussed offline, but documenting here for alignment]
Only callout here is that ModularAccountBase has the upgradeToAndCall function which doesn't make sense for the 7702 flow. If we want to tidy things up a bit and reduce an external function, we can probably pull this function out into another base class and exclude it here. Is this worth it? cc @alchemyplatform/contractoors .
There was a problem hiding this comment.
Right, since we're not using any proxy layer, this makes sense. I wonder if it's worth the added "extra hops"
There was a problem hiding this comment.
It would just be a tiny bit code saved on 7702 SMAs. Require duplicated impl on both MA and other SMAs.
We could disable the upgrade for SMA7702 though. Updated.
fangting-alchemy
force-pushed
the
7702
branch
from
29f57fe to
7e6263a
Compare
fangting-alchemy
force-pushed
the
7702
branch
from
7e6263a to
024b620
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Support EIP-7702 EOA delegation with semi modular account.
Solution
Default fallback signer to
address(this)aka EOA address for 7702 EOA account.