fix(rpc): fix gas estimation error decoding #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dancoombs
commented
Jul 20, 2023
dancoombs
commented
Jul 20, 2023
Comment on lines
+146
to
+147
| } else if let Ok(err) = ContractRevertError::decode(&revert_data) { | ||
| Ok(Err(err.reason)) |
There was a problem hiding this comment.
Annoyingly the Entrypoint contract sometimes likes to use require(..., "AAxx ...") instead of revert FailedOp(...).
dphilipson
approved these changes
Jul 20, 2023
dancoombs
force-pushed
the
danc/fix-estimation-err-decode
branch
from
ce2d6b6
to
a40bdaf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.