Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sim): only allow account to access storage on creation with stake… #345

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

dancoombs
Copy link
Collaborator

…d factory

@dancoombs dancoombs requested review from a team, dphilipson, alex-miao and 0xfourzerofour and removed request for a team September 5, 2023 20:22
@dancoombs dancoombs marked this pull request as draft September 5, 2023 20:22
@dancoombs dancoombs force-pushed the danc/wallet-creation-storage-access branch from 5786775 to e10fcf5 Compare September 7, 2023 15:39
@dancoombs dancoombs marked this pull request as ready for review September 7, 2023 15:39
@dancoombs dancoombs force-pushed the danc/wallet-creation-storage-access branch 2 times, most recently from f1fc290 to 54dc843 Compare September 7, 2023 15:42
Copy link
Collaborator

@0xfourzerofour 0xfourzerofour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@dphilipson dphilipson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

src/common/simulation.rs Outdated Show resolved Hide resolved
src/common/simulation.rs Outdated Show resolved Hide resolved
src/common/simulation.rs Outdated Show resolved Hide resolved
@dancoombs dancoombs force-pushed the danc/wallet-creation-storage-access branch from 54dc843 to 1a27632 Compare September 7, 2023 18:04
@dancoombs dancoombs force-pushed the danc/wallet-creation-storage-access branch from 1a27632 to 4e7dc8d Compare September 7, 2023 21:36
@dancoombs dancoombs merged commit 52c0d6c into main Sep 7, 2023
5 checks passed
@dancoombs dancoombs deleted the danc/wallet-creation-storage-access branch September 7, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants