[WIP] feat(network): initial gossip implementation #465
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#248
Proposed Changes
3 big spec issues currently:
message_id
doesn't allow the message to be sent across multiple topics. It currently gets deduplicated before being forwarded on the 2nd topic. There are 2 solutions here both with downsides.a. Include the topic in the
message_id
. This is how the latest consensus spec defines them. The downside is that the messages will get sent/received across all topics.b. Somehow get the libp2p spec changed to allow the same message_id to be propagated across multiple topics.
Relevant section: https://github.com/libp2p/specs/blob/master/pubsub/gossipsub/gossipsub-v1.0.md#message-cache
Going to write these things up and propose changes to the p2p spec.