Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rpc): add debug_bundler_clearMempool endpoint #568

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

alex-miao
Copy link
Collaborator

Proposed Changes

@alex-miao alex-miao changed the base branch from main to alex/urep-020 January 25, 2024 06:17
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 43 lines in your changes are missing coverage. Please review.

Comparison is base (cc23515) 57.15% compared to head (e7c003e) 57.06%.

Additional details and impacted files

Impacted file tree graph

Files Coverage Δ
crates/pool/src/mempool/mod.rs 87.36% <ø> (ø)
crates/pool/src/server/mod.rs 25.00% <ø> (ø)
crates/pool/src/mempool/uo_pool.rs 87.98% <83.33%> (-0.08%) ⬇️
crates/pool/src/mempool/reputation.rs 75.32% <0.00%> (-1.50%) ⬇️
crates/pool/src/server/remote/server.rs 0.00% <0.00%> (ø)
crates/pool/src/server/remote/client.rs 0.00% <0.00%> (ø)
crates/rpc/src/debug.rs 0.00% <0.00%> (ø)
crates/pool/src/server/local.rs 45.85% <0.00%> (-0.80%) ⬇️
Flag Coverage Δ
unit-tests 57.06% <18.86%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
rundler binary 0.00% <ø> (ø)
builder 50.09% <ø> (ø)
dev 0.00% <ø> (ø)
pool 63.71% <22.72%> (-0.25%) ⬇️
provider 0.91% <ø> (ø)
rpc 37.18% <0.00%> (-0.25%) ⬇️
sim 83.51% <ø> (ø)
tasks ∅ <ø> (∅)
types 90.25% <ø> (ø)
utils 14.96% <ø> (ø)

@dancoombs
Copy link
Collaborator

This looks like it includes a bunch of code from your other PR, let us know once its cleaned up so we can see the diff clearly

@alex-miao
Copy link
Collaborator Author

This looks like it includes a bunch of code from your other PR, let us know once its cleaned up so we can see the diff clearly

Got messed up from rebasing the other branch with main, fixed now.

Copy link
Collaborator

@dancoombs dancoombs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

One last nit

Base automatically changed from alex/urep-020 to main January 29, 2024 07:00
Copy link
Collaborator

@dancoombs dancoombs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Collaborator

@0xfourzerofour 0xfourzerofour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, I am going to use some of this logic for the admin methods that I am going to fix

@alex-miao alex-miao merged commit 0099370 into main Jan 29, 2024
6 checks passed
@alex-miao alex-miao deleted the alex/debug-clear-mempool branch January 29, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants