-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rpc): add debug_bundler_clearMempool endpoint #568
Conversation
c99e9cb
to
6e42fdc
Compare
Codecov ReportAttention:
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more.
|
c2c2f98
to
0b881ff
Compare
This looks like it includes a bunch of code from your other PR, let us know once its cleaned up so we can see the diff clearly |
6e42fdc
to
c66a536
Compare
Got messed up from rebasing the other branch with main, fixed now. |
3d0ebc1
to
d83e4c2
Compare
c66a536
to
923e7f7
Compare
923e7f7
to
e990f74
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
One last nit
e990f74
to
5638562
Compare
5638562
to
e7c003e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, I am going to use some of this logic for the admin methods that I am going to fix
Proposed Changes
debug_bundler_clearMempool
RPC method which is used in the spec test: https://github.com/alchemyplatform/bundler-spec-tests/blob/12bf62752d4af78ed383e6ec4c1a610ebaea1787/tests/utils.py#L184. The spec test uses the method to clear the mempool but not the reputations, which is why we need a different endpoint thandebug_bundler_clearState