Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chains): add polygon amoy and use alloy-rs #583

Merged
merged 7 commits into from
Feb 6, 2024
Merged

Conversation

0xfourzerofour
Copy link
Collaborator

Add polygon amoy and use alloy-rs for chain definitions

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (2d270fa) 57.06% compared to head (41342a5) 57.29%.
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

Files Coverage Δ
crates/sim/src/estimation/estimation.rs 90.72% <100.00%> (ø)
crates/sim/src/gas/gas.rs 88.97% <100.00%> (ø)
crates/sim/src/precheck.rs 75.60% <100.00%> (ø)
crates/types/src/chain.rs 0.00% <ø> (ø)
crates/builder/src/sender/mod.rs 0.99% <0.00%> (ø)
bin/rundler/src/cli/pool.rs 0.00% <0.00%> (ø)

... and 12 files with indirect coverage changes

Flag Coverage Δ
unit-tests 57.29% <68.75%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
rundler binary 0.00% <0.00%> (ø)
builder 50.09% <0.00%> (ø)
dev 0.00% <ø> (ø)
pool 64.39% <ø> (+0.67%) ⬆️
provider 0.91% <ø> (ø)
rpc 36.16% <ø> (-1.03%) ⬇️
sim 83.51% <100.00%> (ø)
tasks ∅ <ø> (∅)
types 90.25% <ø> (ø)
utils 14.96% <ø> (ø)

@0xfourzerofour 0xfourzerofour marked this pull request as ready for review February 5, 2024 20:11
crates/types/Cargo.toml Outdated Show resolved Hide resolved
Copy link
Collaborator

@dancoombs dancoombs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides the sort nit. Can't wait to remove all these chain references with the ChainSpec.

Lets get that sort nit worked out, this merged, and then cherry-pick this to 0.1.0-beta.0

@0xfourzerofour 0xfourzerofour merged commit bdf1510 into main Feb 6, 2024
6 checks passed
@0xfourzerofour 0xfourzerofour deleted the josh/pgamoy branch February 6, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants