Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(types): add entrypoint 0.7 contract types #633

Closed
wants to merge 15 commits into from

Conversation

dancoombs
Copy link
Collaborator

Proposed Changes

  • Compiles both versions of the entry point contracts
  • Only consumes v0.6 for now, going to begin abstracting these in subsequent PRs

@dancoombs dancoombs force-pushed the danc/contracts-v0_7 branch 3 times, most recently from f8398fc to 46d418e Compare March 5, 2024 23:15
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 57.95%. Comparing base (0054d2b) to head (f5d2c6e).

❗ Current head f5d2c6e differs from pull request most recent head 8c34d77. Consider uploading reports for the commit 8c34d77 to get more accurate results

Additional details and impacted files

Impacted file tree graph

Files Coverage Δ
crates/pool/src/chain.rs 93.46% <ø> (ø)
crates/provider/src/ethers/entry_point.rs 0.00% <ø> (ø)
crates/provider/src/ethers/provider.rs 0.00% <ø> (ø)
crates/provider/src/traits/entry_point.rs 100.00% <ø> (ø)
crates/rpc/src/eth/api.rs 65.62% <ø> (ø)
crates/sim/src/estimation/estimation.rs 92.12% <ø> (ø)
crates/sim/src/simulation/simulation.rs 85.86% <ø> (ø)
crates/sim/src/utils.rs 94.73% <ø> (ø)
crates/types/src/validation_results.rs 60.86% <ø> (ø)
bin/tools/src/bin/send_ops.rs 0.00% <0.00%> (ø)
... and 1 more
Flag Coverage Δ
unit-tests 57.95% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
rundler binary 0.00% <0.00%> (ø)
builder 51.78% <ø> (ø)
dev 0.00% <0.00%> (ø)
pool 64.47% <ø> (ø)
provider 0.41% <ø> (ø)
rpc 34.35% <ø> (ø)
sim 86.57% <ø> (ø)
tasks ∅ <ø> (∅)
types 87.30% <ø> (ø)
utils 16.73% <ø> (ø)

@dancoombs dancoombs changed the base branch from main to feat/v0_7 March 11, 2024 22:00
@dancoombs dancoombs marked this pull request as ready for review March 11, 2024 22:05
Copy link
Collaborator

@0xfourzerofour 0xfourzerofour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit about code reuse

crates/types/build.rs Outdated Show resolved Hide resolved
@dancoombs dancoombs closed this Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants