Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move builder and pool traits to types #640

Merged
merged 9 commits into from
Mar 30, 2024

Conversation

dancoombs
Copy link
Collaborator

Closes #415

Proposed Changes

  • Moves the pool and builder traits and all associated types to the types crate
  • rpc, builder, and pool crates are now all independent

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 37.63103% with 1785 lines in your changes are missing coverage. Please review.

Project coverage is 55.22%. Comparing base (639d1e1) to head (88a96ae).

Additional details and impacted files

Impacted file tree graph

Files Coverage Δ
crates/builder/src/bundle_sender.rs 0.00% <ø> (ø)
crates/builder/src/server/remote/protos.rs 0.00% <ø> (ø)
crates/pool/src/mempool/mod.rs 100.00% <100.00%> (+8.87%) ⬆️
crates/pool/src/mempool/paymaster.rs 93.62% <100.00%> (+0.48%) ⬆️
crates/pool/src/mempool/pool.rs 95.78% <100.00%> (+<0.01%) ⬆️
crates/pool/src/mempool/reputation.rs 85.25% <ø> (+5.02%) ⬆️
crates/pool/src/server/remote/server.rs 0.00% <ø> (ø)
crates/provider/src/traits/entry_point.rs 20.00% <ø> (+7.50%) ⬆️
crates/rpc/src/admin.rs 0.00% <ø> (ø)
crates/rpc/src/eth/events/mod.rs 100.00% <ø> (ø)
... and 60 more

... and 25 files with indirect coverage changes

Flag Coverage Δ
unit-tests 55.22% <37.63%> (-2.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
rundler binary 0.00% <0.00%> (ø)
builder 50.64% <16.32%> (-0.68%) ⬇️
dev 0.00% <0.00%> (ø)
pool 65.38% <65.60%> (+0.46%) ⬆️
provider 9.09% <0.77%> (-4.72%) ⬇️
rpc 29.09% <19.12%> (-3.82%) ⬇️
sim 82.85% <38.29%> (-2.32%) ⬇️
tasks ∅ <ø> (∅)
types 66.48% <35.79%> (-7.35%) ⬇️
utils 16.73% <ø> (-0.07%) ⬇️

Copy link
Collaborator

@dphilipson dphilipson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The refactor makes sense! Left a couple comments as I saw them that are unrelated to this PR.

crates/builder/src/bundle_proposer.rs Outdated Show resolved Hide resolved
crates/types/src/pool/types.rs Outdated Show resolved Hide resolved
@dancoombs dancoombs merged commit 1ee3d4d into danc/rpc-router Mar 30, 2024
7 checks passed
@dancoombs dancoombs deleted the danc/move-traits branch March 30, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants