Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rpc): update jsonrpsee version, rework metrics middleware #773

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

dancoombs
Copy link
Collaborator

Proposed Changes

  • Update jsonrpsee version
  • Required reworking the metrics middleware layer
  • Still cannot update tower to v0.5 due to jsonprsee dependency

0xfourzerofour
0xfourzerofour previously approved these changes Aug 29, 2024
Copy link
Collaborator

@0xfourzerofour 0xfourzerofour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good

andysim3d
andysim3d previously approved these changes Aug 29, 2024
@dancoombs dancoombs force-pushed the danc/update-deps branch 6 times, most recently from f7b4715 to 64f09be Compare August 29, 2024 22:06
Base automatically changed from danc/update-deps to feat/v0.4 August 29, 2024 22:25
@dancoombs dancoombs dismissed stale reviews from andysim3d and 0xfourzerofour August 29, 2024 22:25

The base branch was changed.

@dancoombs dancoombs merged commit facf2c2 into feat/v0.4 Aug 30, 2024
7 of 8 checks passed
@dancoombs dancoombs deleted the danc/update-jsonrpsee branch August 30, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants