Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(middleware): add response extractor. #816

Merged
merged 9 commits into from
Oct 8, 2024
Merged

feat(middleware): add response extractor. #816

merged 9 commits into from
Oct 8, 2024

Conversation

andysim3d
Copy link
Collaborator

@andysim3d andysim3d commented Sep 26, 2024 •
edited
Loading

[Closes/Fixes] #812

Proposed Changes

  • impl a reponse code extractor. choose to use string to represent the response code because the value range various from HTTP(u16) to grpc(i32) to provider(i64). worries there will be wider range in the future so choose string here.

@andysim3d andysim3d force-pushed the andy/repsonse-extractor branch 3 times, most recently from ba6d2d0 to ba1f0c6 Compare September 26, 2024 20:00
@andysim3d andysim3d force-pushed the andy/repsonse-extractor branch 6 times, most recently from 2d289da to 8306857 Compare October 2, 2024 19:39
@andysim3d andysim3d force-pushed the andy/repsonse-extractor branch 2 times, most recently from ae9b9d7 to 8cb8bd5 Compare October 7, 2024 19:45
dancoombs
dancoombs reviewed Oct 7, 2024
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
dancoombs
dancoombs reviewed Oct 7, 2024
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
dancoombs
dancoombs reviewed Oct 8, 2024
View reviewed changes
bin/rundler/Cargo.toml Outdated Show resolved Hide resolved
dancoombs
dancoombs reviewed Oct 8, 2024
View reviewed changes
crates/types/Cargo.toml Outdated

mockall = {workspace = true, optional = true }

[dev-dependencies]
rundler-types = { workspace = true, features = ["test-utils"] }
alloy-primitives = { workspace = true, features = ["rand"] }
cargo-husky = { version = "1", default-features = false, features = ["user-hooks"] }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't this be cargo-husky.workspace = true

@andysim3d andysim3d merged commit 81d88be into feat/v0.4 Oct 8, 2024
8 checks passed
@andysim3d andysim3d deleted the andy/repsonse-extractor branch October 8, 2024 19:03
dancoombs pushed a commit that referenced this pull request Oct 18, 2024
@andysim3d @dancoombs
feat(middleware): add response extractor. (#816)
885cc9c
dancoombs pushed a commit that referenced this pull request Oct 23, 2024
@andysim3d @dancoombs
feat(middleware): add response extractor. (#816)
88b1542
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dancoombs dancoombs dancoombs approved these changes

@dphilipson dphilipson Awaiting requested review from dphilipson dphilipson is a code owner

@alex-miao alex-miao Awaiting requested review from alex-miao alex-miao is a code owner

@0xfourzerofour 0xfourzerofour Awaiting requested review from 0xfourzerofour 0xfourzerofour is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andysim3d @dancoombs @0xfourzerofour