refactor: modify uo gas limit calcs & v0.6 builder #828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dancoombs
requested review from
dphilipson,
0xfourzerofour,
alex-miao and
andysim3d
as code owners
0xfourzerofour
approved these changes
Oct 7, 2024
dancoombs
force-pushed
the
danc/uo-cleanups
branch
from
61f33f1
to
8ff838e
Compare
dancoombs
commented
Oct 7, 2024
dancoombs
commented
Oct 7, 2024
dancoombs
force-pushed
the
danc/uo-cleanups
branch
from
6fdb3e7
to
10471a9
Compare
0xfourzerofour
approved these changes
Oct 7, 2024
andysim3d
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
da_pre_verification_gas_limitfunction for retrieving the DA portion of the PVG as it applies to the gas limit.This work is in preparation for #783 and #744
NOTE: The
TODO(danc): HEREcomments are where I'm planning on updating for #783, they just got caught up in this PR. They'll be removed in the subsequent PR before the feature branch merges.