Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pool): add a configurable maximum time allowed in pool #941

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

dancoombs
Copy link
Collaborator

Closes #936

Proposed Changes

  • Add a configurable maximum amount of time a UO is allowed to be in the pool. Defaults to disabled.

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 97.91667% with 1 line in your changes missing coverage. Please review.

Project coverage is 59.01%. Comparing base (62d6907) to head (30a5119).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
bin/rundler/src/cli/pool.rs 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
crates/pool/src/mempool/mod.rs 100.00% <ø> (ø)
crates/pool/src/mempool/pool.rs 96.72% <100.00%> (+0.12%) ⬆️
crates/pool/src/mempool/uo_pool.rs 92.15% <100.00%> (+<0.01%) ⬆️
crates/types/src/timestamp.rs 98.13% <100.00%> (+0.03%) ⬆️
bin/rundler/src/cli/pool.rs 0.00% <0.00%> (ø)
Flag Coverage Δ
unit-tests 59.01% <97.91%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
rundler binary 0.00% <0.00%> (ø)
builder 65.21% <ø> (ø)
dev ∅ <ø> (∅)
pool 66.72% <100.00%> (+0.17%) ⬆️
provider 19.49% <ø> (ø)
rpc 26.71% <ø> (ø)
sim 77.03% <ø> (ø)
tasks ∅ <ø> (∅)
types 67.65% <100.00%> (+0.04%) ⬆️
utils 30.06% <ø> (ø)

@dancoombs dancoombs force-pushed the danc/max-time-in-pool branch from 05fb525 to cf1c48f Compare January 9, 2025 01:20
@dancoombs dancoombs force-pushed the danc/max-time-in-pool branch from cf1c48f to 30a5119 Compare January 9, 2025 02:20
} else if self
.config
.max_time_in_pool
.is_some_and(|m| op.elapsed_time_in_pool() > m)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, I forgot is_some_and went into stable in like v1.70 i used to always get nightly errors

@dancoombs dancoombs merged commit 7f09531 into main Jan 9, 2025
10 checks passed
@dancoombs dancoombs deleted the danc/max-time-in-pool branch January 9, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[pool] Add a maximum valid time for UOs
2 participants