Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change authorization tuple use hexstirng #972

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

andysim3d
Copy link
Collaborator

[Closes/Fixes] #

Proposed Changes

@andysim3d andysim3d force-pushed the andy/fix-authorization-to-hex branch from 224c6f0 to b877e26 Compare January 9, 2025 16:38
Copy link
Collaborator

@0xfourzerofour 0xfourzerofour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andysim3d andysim3d merged commit cbd0734 into main Jan 9, 2025
9 checks passed
@andysim3d andysim3d deleted the andy/fix-authorization-to-hex branch January 9, 2025 17:57
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 4.16667% with 23 lines in your changes missing coverage. Please review.

Project coverage is 58.97%. Comparing base (5b29e8a) to head (b877e26).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/rpc/src/types/rpc_authorization.rs 0.00% 20 Missing ⚠️
crates/rpc/src/types/v0_7.rs 0.00% 2 Missing ⚠️
crates/rpc/src/types/v0_6.rs 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
crates/rpc/src/types/mod.rs 12.28% <ø> (ø)
crates/rpc/src/types/v0_6.rs 26.22% <50.00%> (ø)
crates/rpc/src/types/v0_7.rs 0.00% <0.00%> (ø)
crates/rpc/src/types/rpc_authorization.rs 0.00% <0.00%> (ø)
Flag Coverage Δ
unit-tests 58.97% <4.16%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
rundler binary 0.00% <ø> (ø)
builder 65.22% <ø> (ø)
dev ∅ <ø> (∅)
pool 66.72% <ø> (ø)
provider 19.49% <ø> (ø)
rpc 26.45% <4.16%> (-0.26%) ⬇️
sim 77.03% <ø> (ø)
tasks ∅ <ø> (∅)
types 67.66% <ø> (ø)
utils 30.06% <ø> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants