Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(7702): use standardized eip7702_auth #973

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

andysim3d
Copy link
Collaborator

@andysim3d andysim3d commented Jan 9, 2025

[Closes/Fixes] #969

Proposed Changes

@0xfourzerofour
Copy link
Collaborator

can you link the docs that show this standard? I cannot find it

@@ -180,7 +180,7 @@ impl From<RpcUserOperationOptionalGas> for UserOperationOptionalGas {
paymaster_post_op_gas_limit: def.paymaster_post_op_gas_limit.map(|x| x.to()),
paymaster_data: def.paymaster_data.unwrap_or_default(),
signature: def.signature,
authorization_contract: def.authorization_contract,
authorization_contract: def.eip7702_auth.map(|a| a.address),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I think we should rework some of the naming here to be more consistent:

Authorization -> Eip7702Auth & RpcEip7702Auth
authorization_contract -> eip7702_auth_address

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for catching! updated

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 23.68421% with 29 lines in your changes missing coverage. Please review.

Project coverage is 58.97%. Comparing base (cbd0734) to head (c2f3c17).

Files with missing lines Patch % Lines
crates/types/src/user_operation/v0_7.rs 14.28% 6 Missing ⚠️
crates/provider/src/alloy/entry_point/v0_6.rs 0.00% 4 Missing ⚠️
crates/rpc/src/types/v0_7.rs 0.00% 4 Missing ⚠️
crates/pool/src/server/remote/protos.rs 0.00% 3 Missing ⚠️
crates/rpc/src/types/rpc_authorization.rs 0.00% 3 Missing ⚠️
crates/rpc/src/types/v0_6.rs 33.33% 2 Missing ⚠️
crates/sim/src/estimation/estimate_call_gas.rs 0.00% 2 Missing ⚠️
crates/utils/src/authorization_utils.rs 0.00% 2 Missing ⚠️
crates/provider/src/alloy/entry_point/v0_7.rs 0.00% 1 Missing ⚠️
crates/types/src/authorization.rs 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
crates/sim/src/estimation/v0_6.rs 95.08% <100.00%> (ø)
crates/sim/src/estimation/v0_7.rs 81.33% <100.00%> (ø)
crates/types/src/user_operation/mod.rs 74.02% <100.00%> (ø)
crates/provider/src/alloy/entry_point/v0_7.rs 0.00% <0.00%> (ø)
crates/types/src/authorization.rs 0.00% <0.00%> (ø)
crates/types/src/user_operation/v0_6.rs 91.75% <75.00%> (ø)
crates/rpc/src/types/v0_6.rs 26.22% <33.33%> (ø)
crates/sim/src/estimation/estimate_call_gas.rs 86.66% <0.00%> (ø)
crates/utils/src/authorization_utils.rs 0.00% <0.00%> (ø)
crates/pool/src/server/remote/protos.rs 2.25% <0.00%> (ø)
... and 4 more
Flag Coverage Δ
unit-tests 58.97% <23.68%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
rundler binary 0.00% <ø> (ø)
builder 65.22% <ø> (ø)
dev ∅ <ø> (∅)
pool 66.72% <0.00%> (ø)
provider 19.49% <0.00%> (ø)
rpc 26.45% <10.00%> (ø)
sim 77.03% <60.00%> (ø)
tasks ∅ <ø> (∅)
types 67.66% <38.46%> (ø)
utils 30.06% <0.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants