-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(7702): use standardized eip7702_auth #973
base: main
Are you sure you want to change the base?
Conversation
can you link the docs that show this standard? I cannot find it |
crates/rpc/src/types/v0_7.rs
Outdated
@@ -180,7 +180,7 @@ impl From<RpcUserOperationOptionalGas> for UserOperationOptionalGas { | |||
paymaster_post_op_gas_limit: def.paymaster_post_op_gas_limit.map(|x| x.to()), | |||
paymaster_data: def.paymaster_data.unwrap_or_default(), | |||
signature: def.signature, | |||
authorization_contract: def.authorization_contract, | |||
authorization_contract: def.eip7702_auth.map(|a| a.address), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I think we should rework some of the naming here to be more consistent:
Authorization
-> Eip7702Auth
& RpcEip7702Auth
authorization_contract
-> eip7702_auth_address
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for catching! updated
[Closes/Fixes] #969
Proposed Changes