Skip to content

feat(network): start network impl and rpc handling #19

feat(network): start network impl and rpc handling

feat(network): start network impl and rpc handling #19

GitHub Actions / clippy failed Oct 11, 2023 in 0s

clippy

1 error

Details

Results

Message level Amount
Internal compiler error 0
Error 1
Warning 0
Note 0
Help 0

Versions

  • rustc 1.71.0 (8ede3aae2 2023-07-12)
  • cargo 1.71.0 (cfd3bbd8f 2023-06-08)
  • clippy 0.1.71 (8ede3aa 2023-07-12)

Annotations

Check failure on line 159 in crates/network/src/rpc/handler/handler.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`

error: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
   --> crates/network/src/rpc/handler/handler.rs:150:13
    |
150 | /             match result {
151 | |                 Ok(((request_id, request), response_sender)) => {
152 | |                     return Poll::Ready(ConnectionHandlerEvent::NotifyBehaviour(
153 | |                         Event::InboundRequest(request_id, request, response_sender),
...   |
158 | |                 }
159 | |             }
    | |_____________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
    = note: `-D clippy::single-match` implied by `-D warnings`
help: try this
    |
150 ~             if let Ok(((request_id, request), response_sender)) = result {
151 +                 return Poll::Ready(ConnectionHandlerEvent::NotifyBehaviour(
152 +                     Event::InboundRequest(request_id, request, response_sender),
153 +                 ))
154 +             }
    |