Skip to content
This repository has been archived by the owner on Aug 19, 2020. It is now read-only.

Use multi-stage builder in single Dockerfile to simplify image build #116

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

YanzheL
Copy link

@YanzheL YanzheL commented Mar 7, 2020

What does this PR do

Multi-stage builder in single Dockerfile

This simplifies the process of building docker images. So we don't need to write complex procedures to do it in Makefile with separate intermediate containers. Users can use this single Dockerfile to create aledbf/kube-keepalived-vip image

Update golang version to 1.14

Golang 1.14 has various performance improvements in runtime and compiler, especially in timer, locks and goroutines (Huge improvement).
See Go 1.14 Release Notes

Update keepalived to v2.0.20

@CLAassistant
Copy link

CLAassistant commented Mar 7, 2020

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 15.014% when pulling 4ff0321 on YanzheL:patch-docker into 121232b on aledbf:master.

@YanzheL
Copy link
Author

YanzheL commented Mar 7, 2020

I already tested and deployed this new image in my cluster. LGTM.

@YanzheL
Copy link
Author

YanzheL commented Mar 7, 2020

@aledbf

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants