Node to View Interface #215
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a511e4a.
Added proxiedFieldPath to input for CustomPortBeh ports Added ability to have property fields for dynamic ports.
Added GetNonRelayEdges List<SerializedEdge> extensions
Ngp changes
Custom behaviour port drawers
Added FieldInfoWithPath as it easier to work with
BaseGraphView uses Param CustomNodeType to create Node on drop
Prepended Custom to ParamNodeType in ExposedParam. Defaults to null
Custom param nodes
Added CustomMenuItem attribute for custom node creation methods CreateNodeMenuWindow now uses a given Func to create a node. Created example.
Can Add Custom Menu Items to Node Menu
OuputAttribute now can target properties Replaced most instances of FieldInfo with MemberInfo
Added ability to use Properties as Outputs
CHORE Extracted child classes in BaseNode to different files ADD ViewDelegates class which allows Node to Access a views data
CHORE Removed unecessary comments BUG Add in missing using to BaseNode.Constructors BUG Position not retained with opening up a saved graph BUG Fixed SetPosition if
|
I can foresee a possible bug in the Node Init where if the position has been changed from the initial position to 0,0 then it would move back to the initial position when opening a saved graph. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added ViewDelegates class that sits in a BaseNode which the NodeView assigns Actions/Funcs relating to things like get/set the current size or position. I did this because I wanted to generate a graph on the fly but I couldn't get the size of the node properly. But it's there anyway to be expanded upon if there's anything in the view that's required to enable certain functionalities.
If the NodeView hasn't initialised yet it modifies the initialposition.
Added the ViewDelegates into BaseNode as View so:
baseNode.View.GetPosition().
baseNode.View.SetPosition(Vector2)
baseNode.View.GetSize()
baseNode.View.GetRect()
baseNode.View.SetRect(Rect)