fix: fetcherPool running forever when no accounts were add to the queue

aleph-im · Sep 26, 2024 · bb27273 · bb27273
1 parent c62e44e
commit bb27273
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/packages/core/src/utils/concurrence/pendingWork.ts b/packages/core/src/utils/concurrence/pendingWork.ts
@@ -161,9 +161,11 @@ export class PendingWorkPool<T> {
     const minSleepTimeRef = await concurrentPromises(generator, concurrency)
 
     const sleep = this.skipSleep
-      ? 1
+      ? 0
       : minSleepTimeRef.value === MAX_TIMER_INTEGER
-      ? this.options.interval
+      ? this.debouncedJob
+        ? undefined
+        : this.options.interval
       : minSleepTimeRef.value
 
     this.skipSleep = false

diff --git a/packages/framework/src/services/fetcher/src/fetcherPool.ts b/packages/framework/src/services/fetcher/src/fetcherPool.ts
@@ -79,6 +79,8 @@ export class FetcherPool<T> extends PendingWorkPool<T> {
     })
   }
 
+  // @note: sleepTime for a fetcher is always between [0, N] never undefined (stop)
+  // in case it should stop the checkComplete will remove it from the pool
   protected async getSleepTime(
     fetcher: BaseHistoryFetcher<any>,
   ): Promise<number> {