Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DNS functionality #165

Merged
merged 3 commits into from
Mar 26, 2024
Merged

Add DNS functionality #165

merged 3 commits into from
Mar 26, 2024

Conversation

MHHukiewitz
Copy link
Member

Build fails due to polyfill not possible on dns Node.js module.

@MHHukiewitz MHHukiewitz marked this pull request as ready for review March 25, 2024 18:16
@MHHukiewitz MHHukiewitz requested a review from aliel March 25, 2024 18:17
@MHHukiewitz
Copy link
Member Author

Couldn't make the polyfill for node.js's dns module (would've been quite difficult to pull off), but I added a warning that this module is only built for Node.js, but can be fixed using a polyfill on the developer-side.

@MHHukiewitz MHHukiewitz merged commit eae5ad9 into main Mar 26, 2024
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliel aliel Awaiting requested review from aliel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MHHukiewitz