Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(message): Parameter added to FORGET a message sent through the permission system #179

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Conversation

RezaRahemtola
Copy link
Contributor

Didn't tested locally but looks pretty straight forward

@hoh hoh requested a review from gmolki August 7, 2024 12:21
Copy link
Member

@gmolki gmolki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Although, as this PR includes no unit tests (I know the test base is not the best 😅) it would be great if you could provide a manual test result to make sure no bugs are introduced.

Thanks 🙏🏻

@gmolki gmolki merged commit 6514c3a into aleph-im:main Aug 7, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants