Fix: Setting API_HOST did not respect SDK settings #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users had to create a distinct `ALEPH_VRF_API_HOST` environment variable to configure it and could not use the SDK's `ALEPH_API_HOST`.
nesitor
reviewed
Feb 28, 2024
| @@ -30,6 +32,10 @@ class Settings(BaseSettings): | |||
| default=None, description="Application private key to post to aleph.im." | |||
| ) | |||
|
|
|||
| @property | |||
| def api_host(self) -> HttpUrl: | |||
| return self.API_HOST or sdk_settings.api_host | |||
There was a problem hiding this comment.
Suggested change
| return self.API_HOST or sdk_settings.api_host | |
| return self.API_HOST or sdk_settings.API_HOST |
I think the SDK don't have the api_host property, like I just checked here: https://github.com/aleph-im/aleph-sdk-python/blob/main/src/aleph/sdk/conf.py#L25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users had to create a distinct
ALEPH_VRF_API_HOSTenvironment variable to configure it and could not use the SDK'sALEPH_API_HOST.