Internal: introduce an Executor class #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nesitor
approved these changes
Sep 22, 2023
nesitor
approved these changes
Sep 22, 2023
src/aleph_vrf/models.py
Outdated
|
|
||
|
|
||
| class LocalNode(Node): | ||
| port: int |
There was a problem hiding this comment.
This port property isn't used at time to set the url.
There was a problem hiding this comment.
No it's basically there for local tests, which are for a following PR. I'll still work on this a bit before merging, not 100% sure this is the right way.
odesenfans
force-pushed
the
od-improve-node-object
branch
2 times, most recently
from
18e180d
to
c03a823
Compare
Problem: the `Node` class assumes that the coordinator will use the
aleph.im compute resource nodes in all cases. We wish to let the user
specify dedicated executor servers as well.
Solution: introduce an `Executor` class that takes a node and an
optional VM function. If running on aleph.im, the API URL of the
executor will be https://{node_url}/vm/{function}, otherwise it will
default to https://{node_url}.
The result dictionaries now use executors as keys as the model is now
hashable.
odesenfans
force-pushed
the
od-improve-node-object
branch
from
c03a823
to
e855a11
Compare
nesitor
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: the
Nodeclass assumes that the coordinator will use the aleph.im compute resource nodes in all cases. We wish to let the user specify dedicated executor servers as well.Solution: introduce an
Executorclass that takes a node and an optional VM function. If running on aleph.im, the API URL of the executor will be https://{node_url}/vm/{function}, otherwise it will default to https://{node_url}.The result dictionaries now use executors as keys as the model is now hashable.