Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add domain support for confidentials #102

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Add domain support for confidentials #102

merged 1 commit into from
Sep 27, 2024

Conversation

philogicae
Copy link
Member

@philogicae philogicae commented Aug 27, 2024 •
edited
Loading

This is a draft, I just wanted to test some stuff and I ended up doing few fixes/improvements:

  • Continued confidential current implementation (needed for the following changes)
  • Fixed /settings/domain/[domain] for cocos
  • Updated /settings/domain/new to add coco support
  • Display the right entity type for cocos

@philogicae philogicae marked this pull request as ready for review August 27, 2024 22:04
@hoh
Copy link
Member

hoh commented Aug 28, 2024

Is this still a draft as described in the body of the PR ?

@philogicae
Copy link
Member Author

Is this still a draft as described in the body of the PR ?

  1. Since the coco instance implementation on front isn't done yet, @amalcaraz / @gmolki have to check if my changes here are fine

  2. I still have to check with @aliel why DNS resolution is currently not working for coco domains, despite the changes

amalcaraz
amalcaraz requested changes Sep 10, 2024
View reviewed changes
Copy link
Collaborator

@amalcaraz amalcaraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor change requested tho

src/components/pages/dashboard/ManageDomain/cmp.tsx Outdated Show resolved Hide resolved
@philogicae philogicae self-assigned this Sep 27, 2024
@philogicae philogicae force-pushed the feature-domain-support-confidentials branch from 1afe274 to 00b3d99 Compare September 27, 2024 14:08
@philogicae philogicae merged commit f81858f into main Sep 27, 2024
1 check passed
@philogicae philogicae deleted the feature-domain-support-confidentials branch September 27, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmolki gmolki Awaiting requested review from gmolki

@amalcaraz amalcaraz Awaiting requested review from amalcaraz

Assignees

@philogicae philogicae

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philogicae @hoh @amalcaraz