Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Broken build #39

Merged
merged 3 commits into from
Aug 7, 2023
Merged

Fix: Broken build #39

merged 3 commits into from
Aug 7, 2023

Conversation

BjrInt
Copy link
Member

@BjrInt BjrInt commented Aug 7, 2023

Project could not be built:

  • Type error when calling the humanReadableSize with an invalid string (mb -> MiB)
  • Importing an undefined constant pricePerMiB
  • Fixed default any on a recursive method (lack of explicit return type)

In order to prevent this from further happening, I added an action that builds the project when opening a PR.

@BjrInt BjrInt requested a review from amalcaraz August 7, 2023 13:30
@amalcaraz amalcaraz merged commit 1509624 into main Aug 7, 2023
1 check passed
@BjrInt BjrInt deleted the Fixes/BjrInt-20230807 branch August 22, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants