Fix: Handle no volume found instead of error 500 #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #581 +/- ##
==========================================
- Coverage 94.67% 94.37% -0.30%
==========================================
Files 89 91 +2
Lines 4770 4908 +138
Branches 652 677 +25
==========================================
+ Hits 4516 4632 +116
- Misses 232 241 +9
- Partials 22 35 +13 ☔ View full report in Codecov by Sentry. |
Psycojoker
approved these changes
Jul 17, 2024
hoh
reviewed
Jul 19, 2024
| required_tokens = compute_flow_cost(session=session, content=content) | ||
| else: | ||
| required_tokens = compute_cost(session=session, content=content) | ||
| except RuntimeError as e: |
There was a problem hiding this comment.
Can you explain why is a RuntimeError error expected here ? Is that error not too generic ?
There was a problem hiding this comment.
Where it can failed
It's in order to handle this error if volume is removed but not the program
nesitor
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Problem:
When a volume is not found, it's returning error 500 instead of returning a web response
Solution:
Catch runtime error and return the error as web error