replace FoldCase by IsText and use simple case folding #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The toFoldCase function of Data.Text massively increases compilation times with recent versions of GHC. In this package the simpler case folding implementation of the toLower function in Data.Char is sufficient. This is a backward incompatible API change since the scope of the respective functions is excludes the ByteString instances of IsString and FoldCase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The toFoldCase function of Data.Text massively increases compilation times
with recent versions of GHC. In this package the simpler case folding
implementation of the toLower function in Data.Char is sufficient.
This is a backward incompatible API change since the scope of
the respective functions is excludes the ByteString instances of
IsString and FoldCase.