Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/lightcurve charts values #315

Merged
merged 6 commits into from
Aug 27, 2024
Merged

Conversation

AlxEnashi
Copy link
Contributor

Summary of the changes

Add service value to confirmap
using overide name to set the deplotment full name
changign some direct lightcurve reference to service

Observations

<-- Add some notes to keep in mind !-->

If the change is BREAKING, please give more details about the breaking changes

<-- What change breaks what and how !-->

Components that need updates and steps to follow

<-- Link repos or other PRs !-->

About this PR:

  • You added the necessary documentation for the team to understand your work.
  • You linked this PR to the corresponding issue or user story.
  • Your changes fulfill the Definition of Done of the issue or user story.
  • Your changes were tested with manual testing before being submitted.
  • Your changes were tested with automatic unit tests.
  • Your changes were tested with automatic integration tests.

Screensshots

<-- Add some screenshots if necessary !-->

@AlxEnashi AlxEnashi requested a review from HectorxH August 26, 2024 20:36
Copy link
Contributor

@HectorxH HectorxH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otras cosas que vi que aun referencian explicitamente lightcurve:

  • El namespace en values
  • Nombre y Descripcion del chart
  • Nombre del volumen de nginx en el deploy
  • Nombre y config de nginx en el configmap
  • Nombre y Path del ingress

No se si esas cosas sean necesarias de cambiar pero lo dejo escrito de todas formas.

El resto de los cambios se ven bien.

@AlxEnashi AlxEnashi merged commit 5375a27 into main Aug 27, 2024
4 checks passed
@AlxEnashi AlxEnashi deleted the refactor/lightcurve_charts_values branch August 27, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants