Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crossmatch #338

Merged
merged 5 commits into from
Oct 22, 2024
Merged

Crossmatch #338

merged 5 commits into from
Oct 22, 2024

Conversation

claudiomansillab
Copy link
Contributor

Crossmatch Changes

@claudiomansillab
Update get_crossmatch_data.py
e007f80 
Deleted unnecesary if statement
@claudiomansillab
Update rest.py
5159be2 
changed route to healtcheck function
@claudiomansillab
Update get_crossmatch_data.py
8c83ae8 
added deleted return response to get_alerce_data function
HectorxH
HectorxH reviewed Oct 22, 2024
View reviewed changes
Copy link
Contributor

@HectorxH HectorxH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solo un pequeño comentario con respecto al uso de list el resto se ve bien.

lightcurve/src/crossmatch_api/routes/htmx.py Outdated Show resolved Hide resolved
lightcurve/src/crossmatch_api/routes/htmx.py Outdated Show resolved Hide resolved
@claudiomansillab
Update htmx.py
b71c1a5 
changed list function to next function to achieve an optimal performance
@claudiomansillab claudiomansillab merged commit fbb6472 into main Oct 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Demurest Demurest Demurest approved these changes

@HectorxH HectorxH HectorxH approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@claudiomansillab @HectorxH @Demurest