Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icons independence #344

Merged
merged 3 commits into from
Nov 18, 2024
Merged

icons independence #344

merged 3 commits into from
Nov 18, 2024

Conversation

Demurest
Copy link
Contributor

Summary of the changes

  • En la API de lightcurve se elimino el "link" a la librería fontawesome, ahora los iconos se visualizan con "svg".

Observations

If the change is BREAKING, please give more details about the breaking changes

Components that need updates and steps to follow

About this PR:

  • You added the necessary documentation for the team to understand your work.
  • You linked this PR to the corresponding issue or user story.
  • Your changes fulfill the Definition of Done of the issue or user story.
  • Your changes were tested with manual testing before being submitted.
  • Your changes were tested with automatic unit tests.
  • Your changes were tested with automatic integration tests.

Screensshots

iconos

@Demurest Demurest self-assigned this Nov 18, 2024
@Demurest Demurest requested a review from HectorxH November 18, 2024 18:51
Copy link
Contributor

@HectorxH HectorxH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Se van usar los archivos .svg? veo que se agregaron a assets pero en el codigo la info esta hardcodeada.

Si no se van a utilizar deberían ser borrados.
Si se van a utilizar tal vez deberían tener nombres más concisos?

@Demurest Demurest merged commit cc6175a into main Nov 18, 2024
4 checks passed
@Demurest Demurest deleted the feat/icons-library branch December 20, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants